-
Notifications
You must be signed in to change notification settings - Fork 243
FOUR-25187: Processes cannot be created with BPMN files #8398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
caleeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review is the Semantic.xsd matches the official standar https://www.omg.org/spec/BPMN/20100501/Semantic.xsd
|
|
||
| // Some BPMN definitions created in others modelers doesn't comply BPMN 2.0 | ||
| // So, should be fixed | ||
| $fixBpmnSchemaService = new FixBpmnSchemaService(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Register the service and use the Laravel style to register services:
$fixBpmnSchemaService = app(FixBpmnSchemaService::class);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
caleeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to the implementation
|





Issue & Reproduction Steps
The BPMN files generated by the modeler used by the client cannot be imported into PM. However, it works perfectly with other BPMN files from different modelers.
Solution
The XSD definition used by ProcessMaker restricts some definitions found in the client’s BPMN files. A couple of these restrictions have been modified to allow the client’s files to be imported.
How to Test
Create a new process and use one of the BPMN files provided in the ticket.
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-25187
Important Note
With this change, the BPMN files provided by the client can be imported. However, our modeler does not automatically fix the visual layout of certain elements in their designs (likely due to differences in scaling and icon sizes between the two modelers).
Code Review Checklist